Added isIdentityCard for identity card codes validation #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hitbits - please rebase to fix the m/c. |
This function validates data structure and control digit of identity card codes of any country. Only spanish identity card (DNI) validation is implemented at this moment. Fixes #740
|
@profnandaa - Done! |
|
@hitbits - sorry for my delay on this one,I will review it in the next few days. QQ, could you list for me the countries (or link where this info is), that this validator supports? Or is it just Spanish locale alone? 🤔 |
|
@profnandaa - As I say in my commit only Spanish locale is implemented in my PR. Other locales must be added in the future |
profnandaa
approved these changes
Sep 24, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function validates data structure and control digit of identity
card codes of any country.
Only spanish identity card (DNI) validation is implemented at this
moment.
Fixes #740