onValidationComplete sometimes errors when inputs are removed

[sdemjanenko]

The inputKeys points to keys that no longer exist in this.inputs.

[farisj]

Having this same problem.

[meikoudras]

+1

[josercruz01]

+1

[dsteinbach]

+1

Seems to be a race condition. I have the following (mock) setup:

<ul>
   {workExp.map(function(exp, index){
      <li>
         <Input name={"work_exp[" + index + "].title"} value={exp.title} />
         <button onClick={removeWorkExp.bind(self, index)}>X</button>
         {exp.skills.map(function(skill, subindex){
            <Input name={"work_exp[" + index + "].skills[" + subindex + "]"} value={skill} />
         })}
     </li>
   })}
</ul>

When the user clicks X to remove a work experience, work_exp[0].title is unmounted first and validateForm is run too soon and is trying to validate this.inputs["work_exp[0].skills[0]"] which also has been unmounted.

The error is on this line:

https://github.com/christianalfoni/formsy-react/blob/master/src/main.js#L373
"Uncaught TypeError: Cannot read property 'state' of undefined"

Perhaps we want that line to be more defensive?

[Semigradsky]

Hi! The problem arises from the fact that the library is heavily dependent on the input names.
Therefore, problems occur when changing the name of the input.

I tried to get rid of it. See #275

[Semigradsky]

@sdemjanenko @farisj @meikoudras @josercruz01 Hi! Could you test #275 on your code? If everything is fine, I will merge it.

[sdemjanenko]

@Semigradsky: test still pass on #258 so all good 😄

[farisj]

@Semigradsky looks good!

[josercruz01]

All good on my side as well @Semigradsky, thanks a lot for the fast response on this.

[dsteinbach]

Worked for me, thanks!

[C3PablO]

Works nice! Thanks! When are you planning next release?