Unable to change arrayType to List or IList

[LunaWanderer1]

Describe the bug
When putting arrayType to 'System.Collections.Generic.List' or 'System.Collections.Generic.IList', it stays as ICollection.

OpenAPI Specifications
Here is an example of the one that is failing:

 "/Auth/domains": {
   "get": {
     "tags": [
       "Auth"
     ],
     "responses": {
       "200": {
         "description": "Success",
         "content": {
           "text/plain": {
             "schema": {
               "type": "array",
               "items": {
                 "type": "string"
               }
             }
           },
           "application/json": {
             "schema": {
               "type": "array",
               "items": {
                 "type": "string"
               }
             }
           },
           "text/json": {
             "schema": {
               "type": "array",
               "items": {
                 "type": "string"
               }
             }
           }
         }
       }
     }
   }
 },

Additional context

Ran using: dotnet refitter --skip-validation --settings-file openapi.json

refitterconfig looks like this:

{
	"openApiPath": "swagger.json",
	"namespace": "DotNetApp",
	"naming": {
		"useOpenApiTitle": false,
		"interfaceName": "ApiClient"
	},
	"contractsGeneratorSettings": {
		"arrayType": "System.Collections.Generic.List"
	},
	"returnIApiResponse": true
}

[christianhelle]

@eliyammine thanks for taking the time to report this

Let me see what I can do

By the way, do you have a support key?

[christianhelle]

@eliyammine one quick thing I noticed in your .refitter config file is that you are using contractsGeneratorSettings instead of codeGeneratorSettings. Can you try out using codeGeneratorSettings ?

[LunaWanderer1]

Hi,

My support key is aurkbqh. I tried with codeGeneratorSettings both with IList and List and no luck

[christianhelle]

You're right @eliyammine. It seems that in the Refit interface, arrays are generated as ICollection<T>. The generated contracts seem to be correct and use IList

I'll see what I can do...

[christianhelle]

@all-contributors please add @eliyammine for bugs

[allcontributors]

@christianhelle

I've put up a pull request to add @eliyammine! 🎉

[christianhelle]

@eliyammine I have a fix for arrayType in the Refit interface that I will merge in.

I will try resolve all the other codeGeneratorSettings return type settings over the Christmas holidays

[christianhelle]

@eliyammine I published a pre-release version to NuGet

dotnet tool install --global Refitter --version 0.8.7.40-preview

that contains a fix for this specific problem.

I bumped the target framework to .NET 8.0 since it is now the new recommended LTS version and because .NET 6.0 is going out of support soon

[LunaWanderer1]

Thank you for the quick fix! Worked perfectly