Not so nice behavior when generating client with trim-unused-schema

[kirides]

Describe the bug
A bunch of "Anonymous" classes get generated.

This is due to the SchemaCleaner not handling DiscriminatorObject.Mapping

Now we have two ways to solve it:

1. always include all "sum type" instances. This leads to more unused schema being generated.
2. remove trimmed-schema from the DiscriminatorObject.Mapping, leading to less generated code

@christianhelle What would you prefer?
Always generate full inheritance hierarchy/sum types or remove the unused discriminated values?

OpenAPI Specifications

a snippet of the issue causing schema:

{
  "SomeContract": {
    "allOf": [
      {
        "$ref": "#/components/schemas/ContractBase"
      },
      {
        "type": "object",
        "discriminator": {
          "propertyName": "$type",
          "mapping": {
            "A": "#/components/schemas/A",
            "B": "#/components/schemas/B",
            "C": "#/components/schemas/C"
          }
        },
        "x-abstract": true,
        "additionalProperties": false,
        "required": ["$type"],
        "properties": {
          "$type": {
            "type": "string"
          }
        }
      }
    ]
  }
}

Additional context
Add any other context about the problem here.

[christianhelle]

@kirides removing unused discriminated values sounds better. You had me at "less generated code" 😄

[kirides]

Possible issues include a fully abstract endpoint that returns SomeContract would not generate all possibly returned types, same with input parameters.

[christianhelle]

@kirides Could we perhaps provide an option to use one or the other?

[kirides]

Best would be some kind of Per-Operation configuration overrides, but that doesn't exist yet.

A simpler "KeepDiscriminatedSchema" would be a one or none switch to support 1. & 2. Globally.

Before going into PR i'd like a suggestion which direction to head into ;)

[christianhelle]

@kirides I can't see myself using a per-operation configuration override, and in scenarios where I would see this, the entire OpenAPI spec would be full of these examples. I'm of course, speaking only for myself

I would, personally, go for a one-or-none switch to support scenario 1 or 2

[kirides]

I've got some code to do that.

Will open a PR after holidays