Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I make it so the script only shows the files that has filesize in it? #36

Open
uugaabuugaa opened this issue Feb 14, 2024 · 3 comments

Comments

@uugaabuugaa
Copy link

uugaabuugaa commented Feb 14, 2024

It's a weird problem I'm facing. I can play everything but vp9 files that don't have filesizes in the formatting. Idk why but after about a minute or so the video stops playing although I can see mpv keeps using network to download it. So if there's a way to change the script to only be able show or play the files with calculated filesizes would be best for me. I can't totally change ytdl format to avc1 because most videos over 1080p require either vp9 or av1 formats. Also doing it would declutter the menu as well I think.

@christoph-heinrich
Copy link
Owner

I think those vp9 formats are for YouTube premium, they don't work for me either.
I'm not really looking to reimplement the format filtering functionality of ytdl.
It's easiest to simply ignore those formats, even if they clutter up the menu.

@uugaabuugaa
Copy link
Author

Ahh that sucks. Thanks anyway for the response.

@christoph-heinrich
Copy link
Owner

christoph-heinrich commented Feb 18, 2024

Ever since you brought that up, the idea of filtering the formats keeps popping in my head, so chances are I'll end up implementing it at some point.

I don't really know how the filtering should work though, because filtering those youtube formats out shouldn't accidentally hide formats from other platforms, so the filter it should probably be tied to a domain.
The easiest would be to provide a list of format IDs that shouldn't be shown, but something more general like the syntax ytdl uses would improve usability a lot. However I'd expect that to also be a PITA to implement...

Let me know if you have any suggestions for how that should work.

No ETA for when I'll get around to this though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants