Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Auth provider proposed API #967

Open
2 tasks
vscodebot bot opened this issue Jan 27, 2020 · 0 comments
Open
2 tasks

Test: Auth provider proposed API #967

vscodebot bot opened this issue Jan 27, 2020 · 0 comments
Labels

Comments

@vscodebot
Copy link

vscodebot bot commented Jan 27, 2020

Testing [https://github.com/microsoft/vscode/issues/88309](Auth provider proposed api}

  • anyOS
  • anyOS

Complexity: 4


The proposal for the authentication provider API currently looks like:
https://github.com/microsoft/vscode/blob/8d36d09ee78e9b2be62cba2f7f686341c062575b/src/vs/vscode.proposed.d.ts!L21-L60

This API enables two different use cases: I can write and register my own auth provider, or I can access existing auth providers and leverage them. The first part of this has been fairly well tested by work I've done for settings sync and for creating a GitHub provider. Please review this part of the API and give any feedback you have about it, but focus on testing using authentication.providers and authentication.onDid[Un]RegisterAuthenticationProvider events. A provider with id "MSA" which supplies the auth for settings sync should be available.
Please test that

  • You can access this provider and call methods on it from an extension
  • When you call getSessions or login, a dialog asking for user consent is shown
@vscodetestbot vscodetestbot bot added the api label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants