Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Add Segment Caches thread-safety #3335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG]: Add Segment Caches thread-safety #3335

wants to merge 1 commit into from

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Dec 19, 2024

Description of changes

Closes #3334

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes the lack of thread-safety of Basic and LRU segment caches by adding RLocks.
    • Add tests to verify the thread-safety
    • Implement simple state-machine property test to verify the LRU cache implementation

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov Graphite App
Copy link
Contributor Author

tazarov commented Dec 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rescrv rescrv rescrv approved these changes

@codetheweb codetheweb Awaiting requested review from codetheweb

@itaismith itaismith Awaiting requested review from itaismith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Basic/LRU Segment Cache is not thread-safe
2 participants
@tazarov @rescrv