Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar with changes & accepting snapshots #236

Open
ghengeveld opened this issue Mar 22, 2024 · 1 comment
Open

Sidebar with changes & accepting snapshots #236

ghengeveld opened this issue Mar 22, 2024 · 1 comment
Labels
bug Classification: Something isn't working sev:S3

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024

From AP-4223

How is the user affected? And what is the expected behavior?

I have the changes filter on for the sidebar. I accept a change in VTA.

When I accept the change, I do not expect the currently highlighted item to disappear immediately because that makes me wonder which story I'm viewing. I expect it to no longer have the yellow badge and persist in the sidebar until I go to another change in the sidebar.

2024-02-08 17 16 43

@ghengeveld ghengeveld added bug Classification: Something isn't working sev:S3 labels Mar 22, 2024
@MichaelArestad
Copy link
Contributor

Comments from original ticket:

Might require help from Storybook team to make sure that we do not filter the item out until we change to another story.
via @thafryer

I think this boils down to "always show currently selected story even if it doesn't match the filter".
via @ghengeveld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working sev:S3
Projects
None yet
Development

No branches or pull requests

2 participants