Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] AddAssign/SubAssign implementation to chrono::Duration #1054

Closed
eval-exec opened this issue May 9, 2023 · 3 comments
Closed

[Feature Request] AddAssign/SubAssign implementation to chrono::Duration #1054

eval-exec opened this issue May 9, 2023 · 3 comments

Comments

@eval-exec
Copy link

We have AddAssign/SubAssign implementation for DateTime/Date this PR: #698

And I think it would be more convinient if there are AddAssign/SubAssign implementation for chrono::Duration
@djc
Copy link
Member

djc commented May 9, 2023

We currently maintain compatibility with the time::Duration type depending on features (from time 0.1, which is no longer being maintained), so I think adding this today would be a bit of a compatibility hazard.

@eval-exec
Copy link
Author

Thank you 💟

@pitdicker pitdicker mentioned this issue May 10, 2023
Closed
@djc djc mentioned this issue May 19, 2023
Closed
@pitdicker pitdicker mentioned this issue Jun 8, 2023
Closed
@pitdicker pitdicker mentioned this issue Sep 27, 2023
Merged
@pitdicker
Copy link
Collaborator

Added in #1327.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djc @pitdicker @eval-exec