Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utc::now can fail with dates that are very far into the past/future #1440

Closed
pitdicker opened this issue Feb 14, 2024 · 1 comment
Closed

Utc::now can fail with dates that are very far into the past/future #1440

pitdicker opened this issue Feb 14, 2024 · 1 comment

Comments

@pitdicker
Copy link
Collaborator

See #1421 (comment).

If SystemTime::now() returns a value that is out of range for a DateTime then Utc::now will panic.
I'm not sure if this is worth making that method fallible for.
@pitdicker pitdicker mentioned this issue Feb 14, 2024
Merged
@djc
Copy link
Member

djc commented Feb 14, 2024

You're right, this is kind of silly.

@djc djc closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djc @pitdicker