Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace weekday-number methods with a single days_since method #201

Closed
clarfonthey opened this issue Jan 10, 2018 · 0 comments · Fixed by #1249
Closed

Replace weekday-number methods with a single days_since method #201

clarfonthey opened this issue Jan 10, 2018 · 0 comments · Fixed by #1249

Comments

@clarfonthey
Copy link

Essentially:

number_from_monday() => days_since(Monday) + 1
number_from_sunday() => days_since(Sunday) + 1
num_days_from_monday() => days_since(Monday)
num_days_from_sunday() => days_since(Sunday)

If we want to replace number_from with something I'd probably go with days_since_plus_one or something more explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Weekday::days_since. pitdicker/chrono
1 participant
@clarfonthey