Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should have bumped to 0.5 when you made the change that caused Alex-PK/chrono-locale#5 #899

Closed
ctrlcctrlv opened this issue Nov 26, 2022 · 3 comments

Comments

@ctrlcctrlv
Copy link

ctrlcctrlv commented Nov 26, 2022

FYI. Patched by Alex-PK/chrono-locale#6 but @Alex-PK hasn't merged anything since 2018 so maybe you want to review this.

@ctrlcctrlv ctrlcctrlv changed the title You should have bumped to 0.5 when you made the change that caused chrono_locale#5 You should have bumped to 0.5 when you made the change that caused Alex-PK/chrono_locale#5 Nov 26, 2022
@ctrlcctrlv ctrlcctrlv changed the title You should have bumped to 0.5 when you made the change that caused Alex-PK/chrono_locale#5 You should have bumped to 0.5 when you made the change that caused Alex-PK/chrono-locale#5 Nov 26, 2022
@djc
Copy link
Member

djc commented Nov 28, 2022

Hmm, that's a tricky one. There's an Internal variant that tries to make it clear that this is intended to be non-exhaustive, but clearly it's not entirely effective. Given that this hasn't been much of an issue, I don't think we're going to go back and fix the semver issue here now. We should start by making some types explicitly non-exhaustive now that we've bumped the MSRV on main.

Are you aware with the built-in localization support that chrono offers?

@ctrlcctrlv
Copy link
Author

ctrlcctrlv commented Nov 28, 2022

Well, it broke one of my font editor's core libraries, ipc.rlib. From its name, you can assume that that library is included in every binary in the MFEK org pretty much.

Regarding unstable-locales, no, was not aware of it, and ipc.rlib far predates it. But I can look into changing to it when it's stabilized, my patch Alex-PK/chrono-locale#6 fixes the problem for me and the MFEK org can just maintain that library for as long as it takes to stabilize.

@pitdicker
Copy link
Collaborator

I don't think there is anything that can be done by now, removing the enum variants after 4 releases would also be a breaking change.

@pitdicker pitdicker closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants