Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style fixes from clj-kondo's linter with default :off #273

Closed
niyarin opened this issue May 30, 2023 · 0 comments
Closed

Coding style fixes from clj-kondo's linter with default :off #273

niyarin opened this issue May 30, 2023 · 0 comments
Assignees

Comments

@niyarin
Copy link
Contributor

niyarin commented May 30, 2023

This issue is a answer to comment(#269 (comment))

  • Lists options that clj-kondo defaults to :off that should be introduced.
  • After listing, fix the corresponding code and add the clj-lint-action settings.

Linters that should be introduced

:single-key-in

  • This option warns about get-in and update-in where the number of elements in keys is 1.
  • Cljam reported 1 warning.
./src/cljam/io/fasta/reader.clj:74:39: warning: update-in with single key

:aliased-namespace-symbol

  • This option warns about code that doesn't use namespace aliases.
  • cljam reported 2 warnings.
./src/cljam/tools/cli.clj:332:32: warning: An alias is defined for clojure.java.io: cio
./src/cljam/tools/cli.clj:333:32: warning: An alias is defined for clojure.java.io: cio

Linters that may be introduced

:reduce-without-init
:redundant-fn-wrapper

Linters that may be introduced (without Kibit)

:minus-one :plus-one :equals-true

@niyarin niyarin self-assigned this Jun 5, 2023
@alumi alumi closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants