Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members required for customized toolbar are not exported #191

Closed
justin-hackin opened this issue Dec 22, 2020 · 4 comments · Fixed by #192
Closed

Members required for customized toolbar are not exported #191

justin-hackin opened this issue Dec 22, 2020 · 4 comments · Fixed by #192

Comments

@justin-hackin
Copy link
Contributor

justin-hackin commented Dec 22, 2020

Bug reports:

One can not follow the instructions provided here #134 for customizing toolbar because the toolbar code contains imports relative to the src directory of this project. This requires obscure workarounds so that the dependent project can build the source files of this project.

Features:

Although TOOL_PAN, TOOL_ZOOM_IN, TOOL_ZOOM_OUT, and fitToViewer are exported, ToolbarButton and the icons are not. A simple solution: export ToolbarButton and icon components.

@justin-hackin
Copy link
Contributor Author

Here's a PR #192

However, you might want to consider enabling custom icons as props since I think this is the most common use case and having to copy-paste the existing code is not DRY. Though, in my use case, I also wanted to remove the none tool and props could be provided for this as well.

@chrvadala chrvadala linked a pull request Dec 31, 2020 that will close this issue
@chrvadala
Copy link
Owner

PR released with v3.9.0

@justin-hackin
Copy link
Contributor Author

Thanks again for accepting the PR. You helped me to build this https://www.youtube.com/watch?v=_J6QBTSfmpU

@chrvadala
Copy link
Owner

Wow, your lanterns are awesome and great use of the pan zoom tool!
Thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants