fix: checks only file type instead of the whole mode #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meta node checks the dentry file mode when dealing with CreateDentry request if the target dentry already exists to avoid files replacement with different types, i.e. rename a regular file to overwrite a directory. However, file mode contains permission bits as well as file type bits. And we certainly do not want permissions involved in such situation. So mask the file mode to compare file type bits only. Signed-off-by: Shuoran Liu <shuoranliu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta node checks the dentry file mode when dealing with CreateDentry
request if the target dentry already exists to avoid files replacement
with different types, i.e. rename a regular file to overwrite a
directory. However, file mode contains permission bits as well as file
type bits. And we certainly do not want permissions involved in such
situation. So mask the file mode to compare file type bits only.
Signed-off-by: Shuoran Liu shuoranliu@gmail.com
What this PR does / why we need it:
Fix inappropriate file mode checks in meta node when dealing with create dentry requests.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #N/A
Special notes for your reviewer:
Compare only the file types but not permissions.
Release note:
N/A