Fix: precondition parsing issue #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mervinkid
added
interface/s3
mervinkid
force-pushed
the
fix_precondition_parsing
branch
2 times, most recently
from
1a952c8 to
fdf8f28
Compare
Fix the parsing issue of the two preconditions of If-Match and If-None-Match. We found that the request sent through the AWS S3 SDK included double quotes for the values of these two preconditions. This part is not specified in the AWS S3 API Reference. Affected APIs: HeadObject, GetObject Signed-off-by: Mofei Zhang <mofei2816@gmail.com>
mervinkid
force-pushed
the
fix_precondition_parsing
branch
from
fdf8f28 to
5c7c998
Compare
awzhgw
pushed a commit
that referenced
this pull request
Mar 30, 2023
enhance: ec create partition choose ecnode of partitionSize < maxDiskAvailSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the parsing issue of the two preconditions of If-Match and
If-None-Match.
We found that the request sent through the AWS S3 SDK included
double quotes for the values of these two preconditions.
This part is not specified in the AWS S3 API Reference.
Affected APIs:
Which issue this PR fixes:
NONE
Special notes for your reviewer:
NONE.
Release note:
NONE.