Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: listObjects and listObjectsV2 list result is not expected #769

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Fix: listObjects and listObjectsV2 list result is not expected #769

merged 1 commit into from
Jul 17, 2020

Conversation

LeeYubo
Copy link
Contributor

@LeeYubo LeeYubo commented Jul 17, 2020

What this PR does / why we need it:
Fix:

  1. listObjects and listObjectsV2 list result is incorrect.
  2. listObjects and listObjectsV2 pagination information is incorrect.
  3. Add directory to result (Contents or CommonPrefixes in response) if the directory is eligible.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@LeeYubo
Fix: listObject and listObjectsV2 list result is not expected
1000d72 
Signed-off-by: yuboLee <pangbolee@gmail.com>
@LeeYubo LeeYubo added bug Something isn't working interface/s3 Topic about object storage interface component/objectnode Topic about ObjectNode priority/normal labels Jul 17, 2020
mervinkid
mervinkid approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@mervinkid mervinkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mervinkid mervinkid merged commit 5c80199 into cubefs:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mervinkid mervinkid mervinkid approved these changes

Assignees
No one assigned
Labels
bug Something isn't working component/objectnode Topic about ObjectNode interface/s3 Topic about object storage interface priority/normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeYubo @mervinkid