Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip preflight check log is showing even when the option is off #1

Open
chungweileong94 opened this issue Oct 11, 2020 · 5 comments
Open

Comments

@chungweileong94
Copy link
Owner

No description provided.

@david29832
Copy link

This plugin didn't work for me,
this is how i do it without this plugin:

const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer')
const CracoAntDesignPlugin = require('craco-antd')
const ESLintWebpackPlugin = require('eslint-webpack-plugin')
const WebpackBar = require('webpackbar')

module.exports = {
  webpack: {
    plugins: [
      new WebpackBar({ profile: true }),
      ...(process.env.NODE_ENV === 'development'
        ? [new BundleAnalyzerPlugin({ openAnalyzer: false })]
        : [])
    ]
  },
  plugins: [
    {
      plugin: CracoAntDesignPlugin,
      options: {
      }
    },
    {
      plugin: {
        overrideWebpackConfig: ({webpackConfig, pluginOptions }) => {
          webpackConfig.plugins.map((plugin)=> {
            if(plugin instanceof ESLintWebpackPlugin) {
              plugin.options.quiet = true
              plugin.options.emitWarning = true
            }
          })
          return webpackConfig
        }
      },
      options: {}
    }  ]
}

@chungweileong94
Copy link
Owner Author

@david29832 Have you follow the setup instructions, it seems like you didn't set it up properly.

@david29832
Copy link

david29832 commented Nov 24, 2020

I don't understand everything but when i debugged the craco override functions there was no eslint-loader found and ESLintWebpackPlugin was already there. That's why I just update the config.

Did something change in the latest craco version ?

@chungweileong94
Copy link
Owner Author

@david29832 if the eslint-webpack-plugin already came with CRA, which means you are using CRA v4.
But unfortunately, Craco & this plugin only support CRA v3 at the moment, so the only workaround is to downgrade the CRA to v3😕

dilanx/craco#205

@david29832
Copy link

oh i probably missed that but i got a good working repo at the moment. It wasn't easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants