Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for updated dependencies #1202

Closed
williamhaley opened this issue Feb 4, 2019 · 2 comments
Closed

New release for updated dependencies #1202

williamhaley opened this issue Feb 4, 2019 · 2 comments

Comments

@williamhaley
Copy link

williamhaley commented Feb 4, 2019

Sorry if I'm off track on this, but...

It seems ember-concurrency version ^0.8.19 is not compatible with Ember 3.6 due to this issue: machty/ember-concurrency#271 (see here too - machty/ember-concurrency#275)

Uncaught TypeError: Class constructor ComputedProperty cannot be invoked without 'new'
    at new TaskProperty
    at task

Seems the latest ember-concurrency resolves that issue.

I see that ember-power-select was updated from ember-concurrency ^0.8.19 here, df6564f

However, I don't think there's been a release of ember-power-select since then. The yarn pkg registries still have power select using the old concurrency addon, and so power select latest isn't working for me on my newly updated Ember app.

Would a new ember-power-select release resolve that? In the meantime I updated my dependency like so "ember-power-select": "cibernox/ember-power-select#df6564fbf785bcd29fe9770661176d0ef1ddef8d" as a workaround in package.json and that's working for the interim.

@Krzyrok
Copy link

Krzyrok commented Feb 11, 2019

If you use yarn, you can try to remove the record (ember-concurrency for ember-power-calendar) from yarn.lock (or equivalent in npm package-lock.json) and reinstall ember-power-select - it should install newer version (compatible with new ember). In my case it helped: machty/ember-concurrency#275 (comment)

@BobrImperator
Copy link

I second that, in my case it did the work too.
It looked like this:

ember-concurrency
Found: 0.8.19, 0.9.0
Project
├── ember-concurrency@0.9.0
├─┬ 
│ └─┬ 
│   ├─┬ ember-power-calendar
│   │ └── ember-concurrency@0.8.19
│   └─┬ ember-power-select
│     └── ember-concurrency@0.8.19
└─┬ 
  ├─┬ ember-power-calendar
  │ └── ember-concurrency@0.8.19
  └─┬ ember-power-select
    └── ember-concurrency@0.8.19

In yarn.lock I've removed:

ember-concurrency@^0.8.1, ember-concurrency@^0.8.19:
  version "0.8.19"
  resolved "https://npm2.ac-project.net/repository/registry.yarnpkg.com-proxy/ember-concurrency/-/ember-concurrency-0.8.19.tgz#71b9c175ba077865310029cb4bdb880e17d5155e"
  integrity sha1-cbnBdboHeGUxACnLS9uIDhfVFV4=
  dependencies:
    babel-core "^6.24.1"
    ember-cli-babel "^6.8.2"
    ember-maybe-import-regenerator "^0.1.5"

then yarn install

and it was swapped to:

ember-concurrency@^0.8.1, ember-concurrency@^0.8.19:
  version "0.8.27"
  resolved "https://registry.yarnpkg.com/ember-concurrency/-/ember-concurrency-0.8.27.tgz#6dd1b9928cf5d13d5ae9c8cd3d5869f6ff81a9a9"
  integrity sha512-2IujJ0Y79a+sHvEOPhUtZ7Ga8HDrwjbQqO7aZ88b0KCsXPro7birQFB508njQSQ0mxrsR9qzDv/KS5V67Cy5dA==
  dependencies:
    babel-core "^6.24.1"
    ember-cli-babel "^6.8.2"
    ember-maybe-import-regenerator "^0.1.5"

Now everything's up and running ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants