Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old(480p) size of player #2

Open
Stepan-H opened this issue Feb 25, 2020 · 2 comments
Open

Old(480p) size of player #2

Stepan-H opened this issue Feb 25, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed low priority Not many resources will be allocated to this issue

Comments

@Stepan-H
Copy link

In old design, player does smaller player, see attachement - pucture ... It's good, because browser load video in 480p when you have automatic resolution...

480p

@NebelNidas
Copy link
Member

Ah, ok, now I understand it. :) This is because the old design had hardcoded widths for the page itself, so every few hundred pixels in width (when a certain height is matched), the page resizes itself to these forced values. The new layout is different: it is actually quite responsive, which in my opinion is the better method. However, you may have noticed that the player itself doesn't resize correctly with my add on, that's because the player width isn't actually responsive but is getting resized with JavaScript. This is bad because I changed the width proportions back to the old design, and now the video player often has white space to the bottom and right. I'm still looking for a fix, and might actually re-implement the old behavior.

@NebelNidas
Copy link
Member

The above mentioned issue with the bars around the player is now fixed with 161d825. However, it's still the new responsive behavior, as the player width gets dictated by JavaScript. So I could fix the page at the 480p size, but the player itself would still get resized according to the actual underlying responsive layout. Maybe could get fixed in the future, but don't expect it anytime soon, as JavaScript debugging really is a pain in the ass... 😅

@NebelNidas NebelNidas added enhancement New feature or request help wanted Extra attention is needed low priority Not many resources will be allocated to this issue labels Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed low priority Not many resources will be allocated to this issue
Projects
None yet
Development

No branches or pull requests

2 participants