Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View for video channels #6

Open
Nicholas-Steel opened this issue Oct 23, 2020 · 8 comments
Open

List View for video channels #6

Nicholas-Steel opened this issue Oct 23, 2020 · 8 comments
Labels
enhancement New feature or request fixed:v0.3

Comments

@Nicholas-Steel
Copy link

Nicholas-Steel commented Oct 23, 2020

https://www.youtube.com/user/GameGrumps/videos
https://www.youtube.com/user/JamesNintendoNerd/videos
etc.

The old non-polymer design of Youtube let you display videos in a List view, Polymer only offers the Grid view. Is it feasible to implement the List View? Below is a comparison of List View and Grid View. (Also can anything be done regarding the white seams when using the Dark Theme?)

Youtube List View
Youtube's grid view

@NebelNidas
Copy link
Member

The list view should be relatively easy, as I would just have to get the thumbnail and description to display side by side and give it a 100% width. It won't look the same as in the old layout, but should be similar enough.
I don't think I'll be able to do anything about the find feature, but I'll look into it.

Also can anything be done regarding the white seams when using the Dark Theme?

As stated in the ReadMe, dark mode isn't supported yet as the extension uses hard-coded overwrites. This is being changed in the currently ongoing refactoring, but as I'm mostly just one person and have very limited time, it unfortunately will be a while until this is finished 😕

@NebelNidas NebelNidas added the enhancement New feature or request label Oct 25, 2020
@Nicholas-Steel
Copy link
Author

Nicholas-Steel commented Oct 26, 2020

I think what happens with the Find feature is that the page has the full name of the videos loaded, it just doesn't visibly display the full name. So if you enter a word in to the Find box that is in a video name but not visible, the browser will scroll the page to where the highlighted word is but you won't be able to see where on the page the highlighted word is since it's invisible.

If your idea gets the full name of the videos visible without mouse hovering over videos than that should fix that.

@NebelNidas
Copy link
Member

NebelNidas commented Nov 26, 2020

I've managed it to work like this:
image

Would this be OK, or do you have ideas for improvements?

Edit: Also, I think the search issue is gone, it was exactly like you described it above 😉

@Nicholas-Steel
Copy link
Author

Yes, that looks very awesome.

@Nicholas-Steel
Copy link
Author

I'm running v0.2.0 and this... doesn't seem to have been implemented? I'm not sure what the fixed:v0.2 tag is supposed to imply on your github.

@NebelNidas
Copy link
Member

Oops, you're right, I postponed the feature to 0.3 and forgot to adjust the tag 😅

@Nicholas-Steel
Copy link
Author

In case anyone else is after this feature, Youtube Redux has just now added support for List View: https://old.reddit.com/r/youtube/comments/jvg4mf/youtube_redux_an_extension_i_made_that_scales/

image

@Nicholas-Steel
Copy link
Author

Any chance of this getting re-supported (currently not working)? I kinda waited a long time to ask this as I realized there was yet another big set of changes made by Youtube and other stuff would sensibly take priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed:v0.3
Projects
None yet
Development

No branches or pull requests

2 participants