feat: Add new rule sumArray #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relekang
force-pushed
the
feat/sumArray
branch
from
41517f4 to
9a1fb94
Compare
rapasoft
suggested changes
Sep 26, 2016
| t.is(sumArray('field', {}, { exact: 100 }), null); | ||
| }); | ||
|
|
||
| test('rules.sumArray should return null for valid exact', t => { |
There was a problem hiding this comment.
This is the same test as on line 5
| ), null); | ||
| }); | ||
|
|
||
| test('rules.sumArray should return "sumArray.min" for invalid max', t => { |
There was a problem hiding this comment.
I think this is a copy/paste type, should be .max
|
|
||
| export default function sumArray(field, value, options) { | ||
| if (!isArray(value)) { | ||
| return null; |
There was a problem hiding this comment.
If value is not an array, shouldn't be returned string sumArray as on the line 30? From my point of view, when a variable number is not float, that means, we have some corrupted value... the same could be valid for this line :)
relekang
force-pushed
the
feat/sumArray
branch
from
9a1fb94 to
6702d81
Compare
|
@rapasoft Fixed up the test, went a bit fast there. |
Usage examples:
{ listOfNumbers: { sumArray: { min: 100, max: 200 } } }
{ listOfObjects: { sumArray: { exact: 100, field: 'percentage' } } }
Fixes #28
relekang
force-pushed
the
feat/sumArray
branch
from
6702d81 to
5c508f2
Compare
PeterCervienka
approved these changes
Sep 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage examples:
Fixes #28