Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.set/get/setProperties vs. destructured Ember.set/get/setProperties #25

Open
sglanzer-deprecated opened this issue Nov 21, 2016 · 0 comments
Milestone

Comments

@sglanzer-deprecated
Copy link
Contributor

sglanzer-deprecated commented Nov 21, 2016

When working in a component/controller context (where this.set, this.setProperties, and this.get exist) prefer the use of this.get, this.set, and this.setProperties.

When working with an object that has been given to us (as a parameter/property for instance) prefer the use of Ember.get(foo, 'propertyName'), Ember.set(foo, 'propertyName') and Ember.setProperties(foo, {}). Destructuring the functions is acceptable const { get } = Ember

@sglanzer-deprecated sglanzer-deprecated added this to the 5.1 milestone Nov 21, 2016
@sglanzer-deprecated sglanzer-deprecated modified the milestone: 5.1 Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant