Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create video module #770

Closed
cieslarmichal opened this issue Jul 1, 2024 · 4 comments · Fixed by #871
Closed

create video module #770

cieslarmichal opened this issue Jul 1, 2024 · 4 comments · Fixed by #871
Assignees
@dubloom
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

new module with following methods:

  • formatName
  • fileExtension
  • videoCodec
  • audioCodec
  • resolution (1920x1080 etc)
  • aspectRatio
  • videoUrl (something like we do for images to generate random url to existing video) its optional as I don't know if something like that exists

ref: https://en.wikipedia.org/wiki/Video_file_format
@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jul 1, 2024
@cieslarmichal cieslarmichal added this to the release v3.0.0 milestone Jul 20, 2024
@cieslarmichal cieslarmichal removed this from the release v3.0.0 milestone Aug 20, 2024
@dubloom
Copy link
Contributor

dubloom commented Aug 23, 2024 •
edited
Loading

Hey, if you are happy with my pull request about esport module, i can deal with this module too

@cieslarmichal
Copy link
Owner Author

Good PR, happy about it, go ahead and take the next one 👍

@dubloom
Copy link
Contributor

dubloom commented Aug 23, 2024

About the video url thing. Would an array of youtube video be a good solution ?

@cieslarmichal
Copy link
Owner Author

I think its fine approach

@cieslarmichal cieslarmichal linked a pull request Aug 23, 2024 that will close this issue
feat: create video module (#770) #871
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubloom dubloom

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create video module (#770) dubloom/faker-cxx
2 participants
@cieslarmichal @dubloom