You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
EDIT: I've just taken a closer look at the readme and this is apparently the intended behaviour. It seems a bit odd to call it delay; something more descriptive like step_delay might be better. I'd also take this opportunity to then suggest that this plugin support an actual delay setting, to delay an animation for a time before playing.
The data-counterup-delay property on an element is not behaving as expected. Assume the following:
This does not cause the animation to delay for 1500, and then animate for 3000. The animation plays immediately but seems to simply not animate any steps for the delay period.
To explain what I mean, look at the numbers above. 1500 is half of 3000; the delay is half the duration. What I'm actually seeing on the page is that the counter will remain at zero, then jump to 6, then remain at 6, then jump to 12.
EDIT: And upon further testing, this behaviour is consistent with other times. For example, setting the delay to 500 causes the counter to jump to 2, then 4, then 6, etc.
I've also tried moving the delay to the JavaScript function:
EDIT: I've just taken a closer look at the readme and this is apparently the intended behaviour. It seems a bit odd to call it
delay
; something more descriptive likestep_delay
might be better. I'd also take this opportunity to then suggest that this plugin support an actualdelay
setting, to delay an animation for a time before playing.The
data-counterup-delay
property on an element is not behaving as expected. Assume the following:On the HTML page:
And in the JavaScript:
This does not cause the animation to delay for 1500, and then animate for 3000. The animation plays immediately but seems to simply not animate any steps for the delay period.
To explain what I mean, look at the numbers above. 1500 is half of 3000; the delay is half the duration. What I'm actually seeing on the page is that the counter will remain at zero, then jump to 6, then remain at 6, then jump to 12.
EDIT: And upon further testing, this behaviour is consistent with other times. For example, setting the delay to 500 causes the counter to jump to 2, then 4, then 6, etc.
I've also tried moving the delay to the JavaScript function:
And the same behaviour is exhibited.
In addition, if the delay is set longer than the duration, the counter will simply not animate at all.
The text was updated successfully, but these errors were encountered: