Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Abillity to pick no processing pages. #779

Open
distample opened this issue Nov 20, 2024 · 6 comments
Open

[Feature Request] Abillity to pick no processing pages. #779

distample opened this issue Nov 20, 2024 · 6 comments

Comments

@distample
Copy link

Hello, could an exception be made for certain pages during conversion?
It would be a cool if the page title contains "noprocessing", KCC will ignore it and leave it in its original form.

For example: Page1.jpg, Page2.jpg, Page3-noprocessing.jpg

@axu2
Copy link
Collaborator

axu2 commented Nov 20, 2024

Why do you want to disable processing? I suspect there's a kcc underlying issue that might be better to fix instead. @distample

@distample
Copy link
Author

distample commented Nov 20, 2024

I don't think it's an issue; purely for aesthetic reasons, I would like the margins not to be cropped on certain pages (1-2 pages per manga volume usually), but other than that, I'm satisfied with the processing of the rest of the volume. @axu2

Example:
Original:
002
Screenshot on kindle after processing:
screenshot_2024_11_20T23_01_44+0300

@neyney10
Copy link
Contributor

@distample Are you using KCC version 7.0.0 with the improved cropping algorithm?

@axu2 If u remember, there was that function that I removed that limited the maximum crop to pages.
Maybe it is for scenarios like this - I think the function would retain page-like aspect ratio and leave the "kaiju no. 8" logo at the bottom left (probably).

@distample
Copy link
Author

distample commented Nov 21, 2024

@neyney10 yes, it's 7.0.0

p.s.: but as far as I remember, the older version gives me the same result

@neyney10
Copy link
Contributor

@neyney10 yes, it's 7.0.0

It seems I've been mistaken. I have just tried your image with KCC 6.2.0 and I end up with the same result.

@neyney10
Copy link
Contributor

However, maybe a more suitable solution is to detect such images with little content and handle them differently while cropping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants