Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send macOS-specific modifier keys (Command, Option) to boot_command #174

Closed
hisaac opened this issue Nov 16, 2024 · 3 comments

Comments

@hisaac
Copy link

hisaac commented Nov 16, 2024

Description

I have a small quality of life improvement I'd love to see in this plugin: The ability to use correct references to macOS-specific modifier keys (Command and Option keys) in the boot_command.

Specifically, what I'd like to have is:

  1. The ability to use <leftCmdOn> and its left/right off/on variants to send the Command key.
  2. The ability to use <leftOptOn> and its left/right off/on variants to send the Option key.

Right now, <leftAlt> an <rightAlt> both map to left and right Command respectively, so I assume these could just be aliased somehow.

I haven't figured out how to send an Option key command yet though, so I'm not sure how that would be implemented.

I'm willing to do this work myself if someone could first give me some guidance or ideas on where and how this modification might be made.

@hisaac
Copy link
Author

hisaac commented Nov 16, 2024

I'm not sure at what layer these changes would need to be made, so I've also opened a matching issue on the hashicorp/packer-plugin-sdk repo: hashicorp/packer-plugin-sdk#266

@edigaryev
Copy link
Contributor

Hi Isaac 👋

hashicorp/packer-plugin-sdk#266 is the correct place to request these enhancements as we simply pass the boot_command to Packer Plugin SDK for parsing.

I haven't figured out how to send an Option key command yet though, so I'm not sure how that would be implemented.

A search for repo:hashicorp/packer-plugin-sdk leftAlt could be a good starting point.

@edigaryev edigaryev closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@hisaac
Copy link
Author

hisaac commented Nov 18, 2024

Sounds good, thanks for the extra info @edigaryev. I did try to do some changes to the packer-plugin-sdk locally in hopes of getting the Option key working, but didn't have much success. I'll see if my question on that repo gets any traction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants