Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TEST_DIR management for Windows #14

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

c4s4
Copy link

@c4s4 c4s4 commented Sep 29, 2016

TEST_DIR was set even if already set by the user. Fixed checking if already set before setting default value.

Verified

This commit was signed with the committer’s verified signature.
ehaas Evan Haas
cirulls pushed a commit to c4s4/xspec that referenced this pull request Sep 29, 2016
- remove TEST_DIR override in batch script as this change is included in a separate pull request (xspec#14)
@cirulls cirulls mentioned this pull request Sep 29, 2016
@cirulls cirulls changed the title Fixed TEST_DIR management for winwdows Fixed TEST_DIR management for Windows Sep 29, 2016
Copy link
Member

@cirulls cirulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I approve it in principle but I want to test it first on Windows. I may be able merge it in a couple of weeks as I don't have direct access to a Windows machine.

@cirulls cirulls merged commit 7f3fef3 into xspec:master Oct 17, 2016
@cirulls
Copy link
Member

cirulls commented Oct 17, 2016

I tested this pull request on a Windows environment and confirm it works fine. Thanks @c4s4 for the pull request.

cirulls pushed a commit that referenced this pull request Oct 17, 2016
output HTML report to custom directory if TEST_DIR is set as environment variable
@cirulls cirulls added this to the v0.5.0 milestone Dec 3, 2016
@cirulls cirulls self-assigned this Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants