Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MergeJson the default behavior #1205

Closed
adhilto opened this issue Jul 8, 2024 · 2 comments · Fixed by #1316
Closed

Make MergeJson the default behavior #1205

adhilto opened this issue Jul 8, 2024 · 2 comments · Fixed by #1316
Assignees
@amart241
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone
Jellyfish

Comments

@adhilto
Copy link
Collaborator

adhilto commented Jul 8, 2024

💡 Summary

Make it so that the various json files output by ScubaGear are merged together by default (see https://github.com/cisagov/ScubaGear/blob/main/docs/configuration/parameters.md#mergejson).

Motivation and context

Having a single file that encompasses all ScubaGear output would increase the portability of ScubaGear reports.

Implementation notes

Dependent on #1023.
@adhilto adhilto added the enhancement This issue or pull request will add new or improve existing functionality label Jul 8, 2024
@adhilto adhilto mentioned this issue Jul 8, 2024
Closed
@schrolla
Copy link
Collaborator

Require checking to see if/how many changes to functional testing and RunCached needed to support this change as well.

@schrolla schrolla added this to the Jellyfish milestone Jul 15, 2024
@amart241 amart241 self-assigned this Aug 19, 2024
@adhilto adhilto mentioned this issue Aug 20, 2024
Merged
20 tasks
@adhilto
Copy link
Collaborator Author

adhilto commented Aug 22, 2024 •
edited
Loading

Per today's meeting: Might also consider renaming the flag. Maybe EnhancedJsonOutput?

@adhilto adhilto mentioned this issue Aug 26, 2024
Closed
@buidav buidav mentioned this issue Sep 16, 2024
Merged
20 tasks
@buidav buidav linked a pull request Sep 16, 2024 that will close this issue
Make ScubaResults.json the default JSON output #1316
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amart241 amart241

Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Milestone
Jellyfish
Development

Successfully merging a pull request may close this issue.

Make ScubaResults.json the default JSON output cisagov/ScubaGear
3 participants
@amart241 @adhilto @schrolla