Sharepoint export provider Get-SPOSite uses deprecated parameter

[tkol2022]

💡 Summary

The Sharepoint export provider Powershell code that calls Get-SPOSite uses a parameter named "Detailed" which is both deprecated and unused by ScubaGear. It should be removed from the code. The same applies to the Get-PnPTenantSite cmdlet - that parameter is not used by ScubaGear in that context either. I tested the code with the parameter removed to ensure that the tool behaves as expected.

Code Fix

Make the following change to the Sharepoint provider. You will notice that I removed the Detailed parameter from the calls to the respective cmdlets.

if ($PnPFlag) {
        $SPOTenant = ConvertTo-Json @($Tracker.TryCommand("Get-PnPTenant"))
        $SPOSite = ConvertTo-Json @($Tracker.TryCommand("Get-PnPTenantSite",@{"Identity"="$($SPOSiteIdentity)";}) | Select-Object -Property *)
        $Tracker.AddSuccessfulCommand("Get-SPOTenant")
        $Tracker.AddSuccessfulCommand("Get-SPOSite")
        $UsedPnP = ConvertTo-Json $true
    }
    else {
        $SPOTenant = ConvertTo-Json @($Tracker.TryCommand("Get-SPOTenant"))
        $SPOSite = ConvertTo-Json @($Tracker.TryCommand("Get-SPOSite", @{"Identity"="$($SPOSiteIdentity)";}) | Select-Object -Property *)
        $Tracker.AddSuccessfulCommand("Get-PnPTenant")
        $Tracker.AddSuccessfulCommand("Get-PnPTenantSite")
    }

[schrolla]

Pair this fix with #1221