Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append UUID to ScubaResults.json by default #1422

Closed
buidav opened this issue Nov 12, 2024 · 0 comments · Fixed by #1426
Closed

Append UUID to ScubaResults.json by default #1422

buidav opened this issue Nov 12, 2024 · 0 comments · Fixed by #1426
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone
Kraken

Comments

@buidav
Copy link
Collaborator

buidav commented Nov 12, 2024 •
edited
Loading

💡 Summary

Request to append the ReportUUID to the end of the ScubaResults.json by default.

Motivation and context

Request from internal teams.

Implementation notes

  • Requires changing the output file name in the MergeJSON function.

Acceptance criteria

  • ScubaResults.json => ScubaResults_{UUID}.json
  • Tests continue to pass even with the file name change.
@buidav buidav added the enhancement This issue or pull request will add new or improve existing functionality label Nov 12, 2024
@schrolla schrolla added this to the Kraken milestone Nov 13, 2024
@adhilto adhilto self-assigned this Nov 13, 2024
@adhilto adhilto mentioned this issue Nov 14, 2024
Merged
21 tasks
@adhilto adhilto linked a pull request Nov 14, 2024 that will close this issue
Add the report UUID to the ScubaResults.json filename #1426
Merged
21 tasks
@rgbrow1949 rgbrow1949 assigned rgbrow1949 and unassigned adhilto and rgbrow1949 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Milestone
Kraken
Development

Successfully merging a pull request may close this issue.

Add the report UUID to the ScubaResults.json filename cisagov/ScubaGear
4 participants
@buidav @adhilto @rgbrow1949 @schrolla