Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the parameters passed into the Scuba config file #1437

Open
Tracked by #1456
buidav opened this issue Nov 20, 2024 · 0 comments
Open
Tracked by #1456

Validate the parameters passed into the Scuba config file #1437

buidav opened this issue Nov 20, 2024 · 0 comments
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Nov 20, 2024

🐛 Summary

Currently if someone use the config file to run Invoke-SCuBA the parameters will bypass the initial validation sets of the parameters at the top of Invoke-SCuBA

To reproduce

Add a parameter that you know will error out to scubaconfig.yaml
Invoke-SCuBA -ConfigFilePath scubaconfig.yaml

Observe the error message.

Expected behavior

For ScubaGear, to validate the parameters passed into the config file on read rather than being enforced down the line.

Any helpful log output or screenshots

Example passing in an invalid -ProductNames within the config file.
The error is caught down the line at Invoke-Connection
Image

@buidav buidav added the bug This issue or pull request addresses broken functionality label Nov 20, 2024
@schrolla schrolla added this to the Lionfish milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

No branches or pull requests

2 participants