Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file has poor (no) defaults #345

Closed
Tracked by #696
gdasher opened this issue May 23, 2023 · 0 comments
Closed
Tracked by #696

Config file has poor (no) defaults #345

gdasher opened this issue May 23, 2023 · 0 comments
Assignees
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@gdasher
Copy link
Collaborator

gdasher commented May 23, 2023

🐛 Summary

When using the command line to pass parameters, there are reasonable default values for all parameters. When using the config file, if you don't provide values for every parameter, the behavior is inconsistent.

To reproduce

Steps to reproduce the behavior:

  1. Create a config file only specifying CapExclusions
  2. Run Invoke-Scuba with said config file.

Expected behavior

What did you expect to happen that didn't?

In some cases, there is logic to handle the resultant missing values and in other cases there is not. Certain values like OpaPath, OutReportName, OutProviderFileName, etc that change rarely should inherit their default values (which are currently specified as default arguments in an unused parameterset).

@gdasher gdasher added this to the Backlog milestone May 23, 2023
@gdasher gdasher added the bug This issue or pull request addresses broken functionality label May 23, 2023
@schrolla schrolla modified the milestones: Backlog, Flipper Jun 8, 2023
@kennethpalmer kennethpalmer self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

No branches or pull requests

3 participants