Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Secure Score Changes from AAD #549

Closed
1 task
ssatyapal123 opened this issue Sep 20, 2023 · 1 comment · Fixed by #556
Closed
1 task

Remove Secure Score Changes from AAD #549

ssatyapal123 opened this issue Sep 20, 2023 · 1 comment · Fixed by #556
Assignees
Labels
bug This issue or pull request addresses broken functionality
Milestone

Comments

@ssatyapal123
Copy link
Contributor

🐛 Summary

The Secure Score Graph cmdlet Get-MgSecuritySecureScore was implemented for MS.AAD.7.2v1 but needs to be removed because of implementation problems. It may be investigated further in Flipper. See #548 for more details.

Steps to Remove Secure Score from MS.AAD.7.2v1

  1. Remove Get-MgSecurityScore call in the AAD provider and its key in the resulting JSON
  2. Remove Microsoft.Graph.Security in the RequiredVersions.ps1 and utils\UninstallModules.ps1 files
  3. Remove Some of the updates to the MS.AAD.7.2v1 test (those integrating secure score, but leave the PolicyID update)
  4. Remove all of the unit test updates

Acceptance Criteria

  • Run the tool against AAD and ensure MS.AAD.7.2v1 shows as Not Implemented (i.e., manual check required)
@ssatyapal123 ssatyapal123 added the bug This issue or pull request addresses broken functionality label Sep 20, 2023
@ssatyapal123 ssatyapal123 added this to the Emerald milestone Sep 20, 2023
@ssatyapal123 ssatyapal123 self-assigned this Sep 20, 2023
@ssatyapal123 ssatyapal123 linked a pull request Sep 25, 2023 that will close this issue
12 tasks
@ssatyapal123
Copy link
Contributor Author

Close issue as PR was merged into emerald.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
1 participant