Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Purview Premium assesment to check status for all users #88

Closed
schrolla opened this issue Dec 22, 2022 · 10 comments · Fixed by #1241
Closed

Update Purview Premium assesment to check status for all users #88

schrolla opened this issue Dec 22, 2022 · 10 comments · Fixed by #1241
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@schrolla
Copy link
Collaborator

schrolla commented Dec 22, 2022

💡 Summary

Recap of this issue where we discovered the advanced audit log for the UAL (renamed to Purview Premium) is enabled on a per-user basis. Each user must also be assigned at minimum a E5/G5 license. Currently in the baseline policy we have 'advanced audit logging SHALL be enabled`. OMB M-21-31, as noted in the baseline policy, also requires that advanced audit logging be turned on. #308 covers the same topic in the SharePoint baseline.

Reposting several points made from the previous issues:

What are the the cons:

  • Requires looping through all the users in both the GUI AND the command-line to enable
  • Requires each user to be assigned an E5/G5 license or a special add-on license.

What are the benefits:

Questions to CISA

  • Do we relegate this policy to a SHOULD? (Answer: No, it remains a SHALL. Related additional specific audit items remain a SHOULD.)
  • Is there another path forward for this policy?

(Initial Issue text)
Follow-up to issue #200, where we discovered that advanced audit is enabled on a per-user basis not tenant-wide (TLRD: we decided to not implement the rego check for the alpha but to reassess the requirement for the MVP).

The cons of advanced audit are pretty self-evident now.

  • Requires looping through all the users in both the GUI AND the command-line to enable (Workaround possible)
  • Requires each user to be assigned an E5/G5 license or a special add-on license (Still true)

What are the benefits? Do they outweigh the cons?

Since this issue was originally created, Microsoft has indicated a change to which events are going to be made available as part of Purview Standard vs Purview Premium. As a result, a careful review of individual audit items needs to be done to determine what specific audit items should be included in the baseline. Regardless, advanced audit (Premium) checks are still desirable.

@schrolla schrolla added this to the Backlog milestone Dec 22, 2022
@schrolla schrolla modified the milestones: Backlog, Emerald Apr 6, 2023
@buidav buidav added the baseline-document Issues relating to the text in the baseline documents themselves label May 2, 2023
@buidav buidav changed the title Assess value of requiring advanced audit Question - Are the advanced audit logs in the UAL worth mandating the requirement that they enabled despite the high licensing level cost May 3, 2023
@buidav buidav added blocked This issue or pull request is awaiting the outcome of another issue or pull request and removed question This issue is a request for information or needs discussion labels May 3, 2023
@gdasher
Copy link
Collaborator

gdasher commented May 4, 2023

My initial sense is that we demote to a should for now given the tradeoffs.

@schrolla
Copy link
Collaborator Author

schrolla commented May 8, 2023

@gdasher Demoting to a SHOULD addresses the policy question, but still leaves it in a difficult state for automating assessment due to the per user nature of the check. Even at a SHOULD, we cannot at this time automate the assessment without serious impact to the time and space required to automatically assess for all users in a tenant with large tenants (wrt users). So the other question here is should we add a policy to the baseline that cannot be easily assessed automatically?

My initial sense is that we demote to a should for now given the tradeoffs.

@gdasher
Copy link
Collaborator

gdasher commented May 11, 2023

I believe its no worse than the status quo situation. We have several policies that can't be easily assessed automatically. This one is particularly egregious though and hard for agencies to implement if they aren't in a position to script it.

Ok, on re-evaluating, I'm ok with removing this one from the baselines until/unless Microsoft adds a tenant level setting to enable.

@gdasher gdasher assigned schrolla and unassigned gdasher May 11, 2023
@schrolla schrolla removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label May 15, 2023
@schrolla
Copy link
Collaborator Author

Based on the previous answer, should this issue be closed as won't fix for now? As I believe there's no further action to take wrt AAD baseline policy.

@schrolla schrolla added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label May 15, 2023
@gdasher
Copy link
Collaborator

gdasher commented May 22, 2023

I think the action is to remove this from the baseline, right? I'm not tracking if its there or not.

@schrolla
Copy link
Collaborator Author

I think the action is to remove this from the baseline, right? I'm not tracking if its there or not.

@gdasher There are currently audit related items from the baseline, but this particular question is around specifically enabling some custom audit items that are only available if Purview Premium is enabled. The implementation details for said implementation are in dependent issue #308. So there is no removal necessary, we would simply close that issue as a won't fix or push to the backlog for re-evaluation at a future date as the action.

@schrolla schrolla changed the title Question - Are the advanced audit logs in the UAL worth mandating the requirement that they enabled despite the high licensing level cost Question - Are the advanced audit logs in the UAL worth mandating the requirement that they are enabled despite the high licensing level cost May 30, 2023
@schrolla
Copy link
Collaborator Author

Waiting on final disposition based on continuing conversations within CISA regarding auditing.

@schrolla
Copy link
Collaborator Author

Waiting on final disposition based on continuing conversations within CISA regarding auditing.

@gdasher Any updates on final disposition of including advanced auditing in the baselines?

@schrolla
Copy link
Collaborator Author

Update from @gdasher indicated that advanced auditing enablement remains in the baselines as a SHALL and that the specific advanced audit items for EXO and SharePoint be a SHOULD item. Currently investigating a possible mechanism for validating these settings with Rego in a performant way.

@schrolla schrolla removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jul 10, 2023
@schrolla schrolla modified the milestones: Emerald, Flipper Sep 26, 2023
@schrolla schrolla modified the milestones: Flipper, Glacier Jan 19, 2024
@schrolla schrolla changed the title Question - Are the advanced audit logs in the UAL worth mandating the requirement that they are enabled despite the high licensing level cost Advanced audit logs in the UAL worth mandating the requirement that they are enabled despite the high licensing level cost Jan 19, 2024
@schrolla
Copy link
Collaborator Author

schrolla commented Feb 5, 2024

Note that the following command allows for server-side filtering and return a count of users in a tenant who have the Advanced Auditing license assigned to them. Can use this compared to full user count to determine if any users are missing from advanced auditing or you can negate the equality below to get a count of those without.

Get-MgBetaUser -Filter "assignedPlans/any(a:a/servicePlanId eq 2f442157-a11c-46b9-ae5b-6e39ff4e5849 and a/capabilityStatus eq 'Enabled')" -ConsistencyLevel eventual -Count userCount -All

This command will return all matching users and set the PowerShell variable $userCount equal to the number of matching users. If the list of users isn't desired, pipe the output to Out-Null. To negate the results to get a count of users without Advanced Auditing licensing assigned, add a 'not' to the beginning of the filter.

@schrolla schrolla changed the title Advanced audit logs in the UAL worth mandating the requirement that they are enabled despite the high licensing level cost Update Purview Premium assesment to check status for all users Feb 5, 2024
@schrolla schrolla modified the milestones: Glacier, Halibut Mar 14, 2024
@schrolla schrolla modified the milestones: Halibut, Iceberg May 9, 2024
@schrolla schrolla added enhancement This issue or pull request will add new or improve existing functionality and removed baseline-document Issues relating to the text in the baseline documents themselves labels Jul 15, 2024
@schrolla schrolla linked a pull request Jul 29, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants