Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pylint Errors #430

Closed
2 tasks
adhilto opened this issue Sep 23, 2024 · 2 comments · Fixed by #499
Closed
2 tasks

Correct pylint Errors #430

adhilto opened this issue Sep 23, 2024 · 2 comments · Fixed by #499
Labels
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented Sep 23, 2024

💡 Summary

Correct the following lint errors:
image

Motivation and context

pylint version 3.3.0, which was just released (Sep 20, 2024), apparently added checks that our code does not currently pass. As a temporary measure I've pinned pylint in the workflow to version 3.2.7. We should update the workflow to the latest version and either refactor our code to pass the checks or configure more exceptions in the workflow.

Implementation notes

pylint version pinned here:

pip install pylint==3.2.7 pytest selenium

Acceptance criteria

  • Workflow uses the latest version of pylint
  • Workflow passes
@snarve snarve added this to the Driftwood milestone Sep 26, 2024
@adhilto adhilto mentioned this issue Nov 14, 2024
13 tasks
@snarve
Copy link
Collaborator

snarve commented Dec 4, 2024

new updates may have resolved this, confirm?

@adhilto
Copy link
Collaborator Author

adhilto commented Dec 5, 2024

new updates may have resolved this, confirm?

Keep open for now, the PR linked to this issue will resolve it, it should close automatically once the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants