Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way for analyst to approve a requested sub organization request #2935

Closed
5 tasks
abroddrick opened this issue Oct 11, 2024 · 2 comments
Closed
5 tasks
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: 🏢 Org Model refinement

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Oct 11, 2024

Issue description

On Portfolio Domain Requests, users have the option to fill in a requested sub organization field and the analysts will need to review this along with the domain request.

As an analyst, I want an easy way to approve the requested sub organization with out having to approve the domain request first.

Acceptance criteria

  • add a button next to the requested suborganization field, "Approve Requested Suborganization"
  • this button should have a confirmation modal
  • upon confirming in the modal, the suborganization is created AND the "suborganization field" is filled in for this domain request
  • The button should go away if the suborganization now exists
  • clicking cancel on the modal window does not create the suborg or alter anything on the request.

Additional context

No response

Links to other issues

@abroddrick abroddrick added dev issue is for the dev team Feature: 🏢 Org Model Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow labels Oct 11, 2024
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Oct 11, 2024
@abroddrick abroddrick moved this from 🎯 Ready to 🍦 Backlog in .gov Product Board Oct 11, 2024
@h-m-f-t
Copy link
Member

h-m-f-t commented Oct 19, 2024

If an analyst wanted to approve a suborganization, couldn't they also just create one manually, separate from the domain request itself? I think that'd be my preferred approach.

Putting the refinement label on it as a flag to discuss (can also just do that in comments).

@h-m-f-t h-m-f-t removed their assignment Oct 23, 2024
@abroddrick
Copy link
Contributor Author

Closing this per the discussion in refinement and org model. We will reopen the investigation of how best to handle approving sub organization requests after M4 is in use.

@abroddrick abroddrick closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@github-project-automation github-project-automation bot moved this from 🍦 Backlog to ✅ Done in .gov Product Board Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team Feature: 🧮 Analyst Experience Issue to improve the Analysts workflow Feature: 🏢 Org Model refinement
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants