Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove S3 lifecycle blocks after we move to version 4.x of Terraform AWS provider #5

Closed
2 tasks done
dav3r opened this issue Jul 22, 2022 · 1 comment · Fixed by #6
Closed
2 tasks done

Remove S3 lifecycle blocks after we move to version 4.x of Terraform AWS provider #5

dav3r opened this issue Jul 22, 2022 · 1 comment · Fixed by #6
Assignees
@dav3r
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@dav3r
Copy link
Member

dav3r commented Jul 22, 2022 •
edited
Loading

💡 Summary

Remove the lifecycle blocks for both S3 buckets in this repository after we move ourselves to version 4.x of the Terraform AWS provider.

Motivation and context

These lifecycle blocks (found here and here) are necessary to prevent Terraform from "flip-flopping" the encryption (removing it and adding it) on subsequent applies. For more info, see hashicorp/terraform-provider-aws#23758.

Implementation notes

None

Acceptance criteria

How do we know when this work is done?

  • Both S3 lifecycle blocks have been removed
  • Consecutive Terraform apply commands do not cause the bucket encryption to be disabled/enabled.
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 22, 2022
@ARSport
Copy link

ARSport commented Oct 4, 2022

Any idea how to prioritize this?

@dav3r dav3r mentioned this issue May 6, 2024
Merged
12 tasks
@dav3r dav3r self-assigned this May 21, 2024
@dav3r dav3r closed this as completed in #6 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dav3r dav3r

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide initial functionality cisagov/publish-egress-ip-terraform
2 participants
@dav3r @ARSport