Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring your own Proto files #55

Open
nleiva opened this issue Jun 4, 2019 · 2 comments
Open

Bring your own Proto files #55

nleiva opened this issue Jun 4, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@nleiva
Copy link
Collaborator

nleiva commented Jun 4, 2019

Now that the vendor folder is gone and we are using Go modules, we can import XR YANG proto files from any repo we want to. Still thinking how we could provide this as a functionality to the user, but all we need to do, to bring a different set of proto files is to modify the importing path of codec_gpb.go, xport_grpc_test.go, pipeline.go, etc. to point to a repo other than github.com/cisco/bigmuddy-network-telemetry-proto. Then compile again.

import (
        ...
	telem "github.com/cisco/bigmuddy-network-telemetry-proto/proto_go"
	pdt "github.com/cisco/bigmuddy-network-telemetry-proto/proto_go/old/telemetry"
        ...
)

Go generate could do this for us, but not sure if it something we want to support.

@remingtonc remingtonc added the enhancement New feature or request label Jun 18, 2019
@remingtonc
Copy link
Contributor

This is what cisco-ie/cisco-proto is for e.g. https://github.com/cisco-ie/cisco-proto/tree/master/codegen/go/xr

@nleiva
Copy link
Collaborator Author

nleiva commented Jun 19, 2019

Right, the question is now whether we want to provide a mechanism to compile Pipeline using any of those. It's something simple to script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants