Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unit tests for wallet/fidelity.rs #79

Closed
Shourya742 opened this issue Jan 6, 2024 · 1 comment · Fixed by #90
Closed

test: Unit tests for wallet/fidelity.rs #79

Shourya742 opened this issue Jan 6, 2024 · 1 comment · Fixed by #90
Labels
good first issue Good for newcomers tests Testing related improvements
Milestone

Comments

@Shourya742
Copy link

Issue Description:
This issue highlights the need for unit tests in our wallet/fidelity.rs file. Currently, several methods and functions in this file are untested, which could lead to potential issues in the future.

Objective:
Write unit tests for each method and associated function in the wallet/fidelity.rs file.

Details:

  • Cover all methods and functions with appropriate test cases.
  • Ensure tests validate functionality, handle edge cases, and check error conditions.
  • Integrate the tests into our existing test suite.
@Shourya742 Shourya742 added good first issue Good for newcomers tests Testing related improvements labels Jan 6, 2024
@rajarshimaitra rajarshimaitra linked a pull request Feb 17, 2024 that will close this issue
@wthrajat
Copy link
Collaborator

After discussion with @rajarshimaitra, most of the methods are now covered by the PR #90 (in both UTs and ITs)
Some methods like update certificate expiry, find the most valued bond, etc remains which should be potentially covered in integration tests (issue for future).
This can be closed.

@rajarshimaitra rajarshimaitra added this to the v0.1.0 milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests Testing related improvements
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants