-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency between how cffconvert
renders url
and the GitHub widget
#397
Comments
In addition there is an inconsistency with handling of The GitHub widget will the DOI and display it in the widget if it is at the top-level. But if it's in |
Hi Alex, thanks for reporting this issue. I agree that it would be helpful for users to have consistency across tooling. In fact I've advocated for it, and proposed a mechanism for how to implement it, here: citation-file-format/citation-file-format#330 (comment) Unfortunately, I expect it might be a while before CFF can achieve consistency across its ecosystem of tools. I feel this is ultimately a funding issue. Best, |
Thanks for bringing this up, Alex! I agree with Jurriaan in that consistency would be nice, but also that it might take a while and is due to funding. I prefer the way this is done in |
I'm happy to make changes to |
If we use the
CITATION.cff
: https://github.com/citation-file-format/cffconvert/blob/main/tests/lib/cff_1_3_0/urls/IRACU/CITATION.cffThe expected output from
cffconvert
prioritizes theurl
in identifiers, e.g. theapalike
test output (https://github.com/citation-file-format/cffconvert/blob/main/tests/lib/cff_1_3_0/urls/IRACU/apalike.txt) is:However if I put that same
.cff
file on a repo, e.g.: https://github.com/alexlancaster/cffconvert_test_cffsand click the "Cite this repository" the output is:
This seems inconsistent to me. I'm aware that the GitHub widget uses the ruby backend, but I would expect that used in the default way that they would be the same, and has implications for what end-users should use for the default
url
, becausecffconvert
is often used internally to generate citations that would be different from GitHub.My sense about what should be prioritized is actually the basic
url
field, because it's a "top-level" field, and I had assumed that would take precedence since you can have multipleurl
inidentifers
that have differentrelation
s to the the thing being documented.E.g. I use it in my own repo: https://github.com/alexlancaster/pypop/blob/citation-cff-zenodo/CITATION.cff to note identifiers like GitHub tags and PyPI repo:
and I also use cffconvert to convert this to
.zenodo.json
which are recognized during the upload. What ends up happening is a skew what is shown as the URL.In contrast, the top-level
url
is more unambigously about the current entity.Not sure what the right solution here is, but this inconsistency should be addressed.
The text was updated successfully, but these errors were encountered: