Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing possibility to disable LEDs #13

Closed
Elarion245 opened this issue May 22, 2023 · 5 comments
Closed

Missing possibility to disable LEDs #13

Elarion245 opened this issue May 22, 2023 · 5 comments
Labels
enhancement New feature or request rock-4c-plus

Comments

@Elarion245
Copy link

Describe the issue you are experiencing

The green power and blue status Led cannot be disabled easily. There should be flags in the haos-config.txt defining if they shall be active or not.

The only workaround I was able to find is described here: https://community.home-assistant.io/t/disable-leds-on-rock-pi/573294/2

Still, a configuration entry would be preferable to a workaround breaking the container...

What operating system image do you use?

rock-4c-plus

What version of Home Assistant Operating System is installed?

10

Did you upgrade the Operating System.

Yes

Steps to reproduce the issue

N/A

Anything in the Supervisor logs that might be useful for us?

N/A

Anything in the Host logs that might be useful for us?

See attached link for a workaround on how to disable the leds. Some guys may also wish to disable the network Leds. Not sure what the commands for that would need to look like.

System information

No response

Additional information

No response

@Elarion245 Elarion245 added the bug Something isn't working label May 22, 2023
@citruz citruz added enhancement New feature or request and removed bug Something isn't working labels May 22, 2023
@citruz
Copy link
Owner

citruz commented May 22, 2023

I am working on adding support for devicetree overlays in the next release. Using these it will be possible to disable the LEDs in the haos-config.txt.
I already have a working overlay to disable the heartbeat led on my 4B+. Unfortunately, the green power led is soldered directly to the voltage supply, so it cannot be turned off on any board except the 4C+ (see https://forum.armbian.com/topic/10980-rockpi4-510-rockchip64-leds/?do=findComment&comment=82886).
For the 4C+ it should work, but I will need to rely on you for testing. I will let you know once I have an image to test.

@Elarion245
Copy link
Author

Sounds great! Will definitely test this, once you are ready

@citruz
Copy link
Owner

citruz commented May 24, 2023

I just published a beta release which adds DT overlays for disabling the LEDs (separately or both).
https://github.com/citruz/haos-rockpi/releases/tag/10.1%2B20230523beta
Just edit haos-config.txt on the boot partition, uncomment the example overlays= line and reboot.
Let me know if you run into any problems.

@Elarion245
Copy link
Author

I just flashed the image - disabling the LEDs via the overlay= works perfectly! Thank a LOT! Now I can go ahead and remove the workaround solution which breaks the Docker container.
(I haven't tested only disabling one, but I guess if disabling both works fine, then also disabling them individually should be fine)

@citruz
Copy link
Owner

citruz commented May 28, 2023

@citruz citruz closed this as completed May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rock-4c-plus
Projects
None yet
Development

No branches or pull requests

2 participants