Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VZE: Fix CR3 for temp records #925

Merged
merged 4 commits into from
Sep 8, 2020
Merged

VZE: Fix CR3 for temp records #925

merged 4 commits into from
Sep 8, 2020

Conversation

sergiogcx
Copy link
Contributor

@sergiogcx sergiogcx commented Sep 4, 2020 •
edited
Loading

For temp records, it shows an alert instead of a download button, even if there is a PDF available:

2020-09-04_17-14-56

To test:

  1. Find any temp record in the staging database. You should see the above Alert.
  2. Change the cr3_stored_flag to 'N', which indicates there is a PDF in S3.
  3. Change the temp_record flag to false, which indicates the record is considered temporary. You show see the download button.
  4. Revert temp_record to true, the button will disappear, even if he cr3_stored_flag is set to 'Y'.

mddilley
mddilley approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and this looks great! The temp records are really getting rounded out with details like this in VZE. 🙌

atd-vze/src/views/Crashes/CR3Record.js
</a>{" "}
for the latest status of this crash.
</Alert>
) : props.isCr3Stored ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I like the chained ternaries. 😎

atd-vze/src/views/Crashes/CR3Record.js Outdated
{props.isTempRecord ? (
<Alert color="warning">
<strong>CR3 PDFs are not available for temporary records.</strong><br />
Using the crash id, check the{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be case ID instead of crash ID?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, it should be the case id!

@sergiogcx sergiogcx merged commit 8950d26 into master Sep 8, 2020
@sergiogcx sergiogcx deleted the 3795-sg-fixcr3s branch October 2, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mddilley mddilley mddilley approved these changes

@mateoclarke mateoclarke Awaiting requested review from mateoclarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiogcx @mddilley