4163 update export csv #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoclarke
approved these changes
Oct 21, 2020
| return; | ||
| } else if (Array.isArray(columnValue)) { | ||
| // If value is array, recursive call and handle objects in array | ||
| flattenRow(columnValue, flattenedRow); | ||
| } else if (typeof columnValue === "object" && columnValue !== null) { | ||
| // If value is object, recursive call and handle k/v pairs in object | ||
| flattenRow(columnValue, flattenedRow); | ||
| } else if (columnName === "death_cnt") { | ||
| // Rename death_cnt column to cris_death_cnt at the request of VZ Team |
There was a problem hiding this comment.
@JaceDeloney, is this rename something that should be happening only for the CSV export? Should we be doing this at a system/database level?
There was a problem hiding this comment.
nvm, @tylerwhitson let me know its only for CSVs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cityofaustin/atd-data-tech#4163
death_cnttocris_death_cntThe only catch is there is a persisting bug that creates empty columns associated with nested objects and appends them at the end of the table. @JaceDeloney I plan to address this in a future issue/PR, but since this is marked as high-priority, we can merge this fix in the meantime.
Zip file with example CSV attached!
atd_txdot_crashes2020-10-21T12_42_42-05_00.csv.zip