Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated pop estimate table and created constant with estimates #942

Merged
merged 7 commits into from
Nov 4, 2020

Conversation

tillyw
Copy link
Contributor

@tillyw tillyw commented Oct 28, 2020

Fixes cityofaustin/atd-data-tech#4215

Replaces population estimate image in information popover with table. Refactored code to stores values for table and By Population module in a constant so they only need to be changed in one location.

Screen Shot 2020-10-27 at 8 38 37 PM

Copy link
Contributor

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement on the hard-coded values and the static image that was here before. Great thinking on setting up a config to make future updates a breeze. 🙌

atd-vzv/src/constants/populationEstimates.js Outdated Show resolved Hide resolved
atd-vzv/src/constants/populationEstimates.js Outdated Show resolved Hide resolved
@tillyw tillyw merged commit f8a546e into master Nov 4, 2020
@tillyw tillyw deleted the 4215_update_VZV_by_population_chart branch November 4, 2020 21:48
Copy link
Contributor

@mateoclarke mateoclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants