Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4188 preview instance #943

Merged
merged 7 commits into from
Oct 29, 2020
Merged

4188 preview instance #943

merged 7 commits into from
Oct 29, 2020

Conversation

tillyw
Copy link
Contributor

@tillyw tillyw commented Oct 28, 2020

Fixes cityofaustin/atd-data-tech#4187
Fixes cityofaustin/atd-data-tech#4188

Adds REACT_APP_VZV_ENVIRONMENT env variable
Adds conditional statements so that when Netlify feeds in that env variable as PREVIEW, the data range is set to go up to the last day of the previous month and the endpoint is set to the test Socrata dataset

Screen Shot 2020-10-29 at 11 09 16 AM

Screen Shot 2020-10-29 at 11 09 33 AM

Screen Shot 2020-10-29 at 11 10 19 AM

@tillyw tillyw force-pushed the 4188_preview_instance branch from b3d5f55 to 70a389c Compare October 28, 2020 21:20
Copy link
Contributor

@mateoclarke mateoclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two files seem out of place and I don't think we should include those changes. Other than that, all good.

atd-vzv/public/index.html Outdated Show resolved Hide resolved
atd-vzv/public/index.backup.html Outdated Show resolved Hide resolved
@tillyw tillyw merged commit 891b1a4 into master Oct 29, 2020
@mateoclarke mateoclarke deleted the 4188_preview_instance branch November 5, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VZV Preview | Create new instance using Netlify config settings VZV Preview | Add new environment variables
2 participants