-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4404 crash narrative crash diagram UI #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions here for you to review. I'm good with this being merged on we can get the deploy preview working without the hardcoding and confirm that the narrative text empty state works as intended.
Fixes cityofaustin/atd-data-tech#4404
Please test with:
https://deploy-preview-956--atd-vze-staging.netlify.app/#/crashes/16876263
See other records to see those with missing diagrams and narratives
Just need to resolve one issue to check the NODE_ENV to set the s3 folder for downloading the image.
Does this: