Add links to various Vision Zero resources to VZE dashboard #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankhereford
added
Impact: 4-None
mddilley
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
This looks great, Frank! Happy to see these important resources linked in the dashboard view with a new reusable component. 🙌
I appreciate you sticking to the conventions of the other widgets that came along with Core UI, and I'm glad that it sparked some discussion about the state of React. 👍 This repo is perfect for seeing how the team learned about function components and hooks.
| icon="fa fa-arrows" | ||
| color="dark" | ||
| link="https://app.powerbigov.us/sharedwithme/reports/42c00944-3a44-4d0a-bdd4-d19d7e3647fe/ReportSection512b18e1068b03c18800?ctid=5c5e19f6-a6ab-4b45-b1d0-be4608a9a67f" | ||
| target='_bi_amd' |
There was a problem hiding this comment.
I was completely unaware of this use of the target attribute! I can't believe that I've never thought referencing an already open window instead of creating a new one each time. Very cool to learn.
Based on feedback from Lewis, the cards which link to external BI dashboards and AGOL maps have had thier icons alinged. For the BI links, due to there not being a brand icon in the FontAwesome collection a 24x24 px raster icon is added, and the relevent react components have been extended to support the use of the icon. Additionally, again based on Lewis' direction, the card indicating the total number of crashes in the current year has been removed. Currently, this is done by commenting out that particular component and related objects, pending a final review by Lewis later this afternoon.
mateoclarke
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.