Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go/Return button on keyboard on android does not trigger the filter on the calendar filter #5057

Open
jairPineros opened this issue Oct 22, 2020 · 1 comment

Comments

@jairPineros
Copy link

jairPineros commented Oct 22, 2020

Describe the bug

A clear and concise description of what the bug is
Go/Return button on keyboard on android does not trigger the filter on the calendar filter

URL

https://janis-v3-4849-filter.netlify.app/en/health-safety/policing-in-austin/police-feedback-and-records/nicks-small-collection/

To Reproduce

Steps to reproduce the behavior
example:

  1. Go to https://janis-v3-4849-filter.netlify.app/en/health-safety/policing-in-austin/police-feedback-and-records/nicks-small-collection/
  2. Click on filter type a date to filter
  3. Click on Go or return button
  4. See error (doesn't activate the filter)

Current behavior

A clear and concise description of what happened

Expected behavior

A clear and concise description of what you expected to happen
Go and return button of the native keyboard in android needs to trigger the filter

Screenshots

Screen Shot 2020-10-21 at 11.32.45 AM.png

Device and browser

Any browser on an Android device.

Additional context

@Niicck
Copy link
Collaborator

Niicck commented Oct 23, 2020

So the question is: do we want pressing the "Go"/">" buttons on mobile to apply the filter? My instinct is to say no. Because not all of the fields are required. I've grouped the keyword input, to date, and from date all into distinct

containers.

The current behavior is that when a user presses "Go" or "Enter", it'll just get rid of the mobile keyboard without applying the filter. Then the user will have the opportunity to fill out other fields or to explicitly press the "Apply Filter" button.

But this behavior could be changed as design sees fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants