Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably enotice on settings form #66

Open
eileenmcnaughton opened this issue Nov 5, 2018 · 0 comments
Open

Probably enotice on settings form #66

eileenmcnaughton opened this issue Nov 5, 2018 · 0 comments

Comments

@eileenmcnaughton
Copy link

I haven't double checked but I was checking settings in conjunction with civicrm/civicrm-core#13048 & I'm pretty sure you will have an enotice on yours as $_settings is not defined - I would recommend changing from extends CRM_Admin_Form_Setting to just CRM_Core_Form - you are not really using functionality from the settings form and it's not really supported as an integration point - I think it could well be completely deleted in the future

Note I recommend the same action for com.cividesk.normalize & com.cividesk.helptab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant